possible endpoint-factory API #242
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meejah
force-pushed
the
tor-endpoint-manager
branch
from
67518e7
to
ca3ec5c
Compare
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
- Coverage 99.94% 98.84% -1.11%
==========================================
Files 20 20
Lines 3662 3721 +59
==========================================
+ Hits 3660 3678 +18
- Misses 2 43 +41
Continue to review full report at Codecov.
|
|
@warner any opinions? would this have made Foolscap's tor-support easier..? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A way to give a completely synchronous Endpoint-returning API for use by "startup"-type code (e.g. before the reactor has been started).
A use-case would be to parse configuration and create endpoints prior to the reactor starting.